« get me outta code hell

simplify log message text construction - mtui - Music Text User Interface - user-friendly command line music player
about summary refs log tree commit diff
diff options
context:
space:
mode:
author(quasar) nebula <towerofnix@gmail.com>2021-03-15 21:57:34 -0300
committer(quasar) nebula <qznebula@protonmail.com>2024-05-16 19:14:12 -0300
commit7ce9093c6a4623f5b87dd01989ebaa0f58a84649 (patch)
tree437c0b08bf886d54b47a82589e9be7656392d56c
parent29a17bd08a040a2883d4b321ec20050b447b9fea (diff)
simplify log message text construction
-rw-r--r--socket.js12
1 files changed, 5 insertions, 7 deletions
diff --git a/socket.js b/socket.js
index db1dfff..f70b95f 100644
--- a/socket.js
+++ b/socket.js
@@ -419,7 +419,7 @@ export function attachBackendToSocketClient(backend, client, {
   function logCommand(command) {
     const nickToMessage = nickname => `\x1b[32;1m${nickname}\x1b[0m`
     const itemToMessage = item => `\x1b[32m"${item.name}"\x1b[0m`
-    let fullmsg = '' // may be overridden
+    let senderNickname = command.sender === 'server' ? 'the server' : command.senderNickname
     let actionmsg = `sent ${command.code} (no action message specified)`
     let isVerbose = false
     switch (command.code) {
@@ -461,7 +461,8 @@ export function attachBackendToSocketClient(backend, client, {
         actionmsg = `seeked to ${getTimeStringsFromSec(command.time, command.time).timeDone}`
         break
       case 'set-nickname':
-        fullmsg = `${nickToMessage(command.nickname)} updated their nickname (from ${nickToMessage(command.oldNickname)})`
+        actionmsg = `updated their nickname (from ${nickToMessage(command.oldNickname)})`
+        senderNickname = command.nickname
         break
       case 'set-pause':
         if (command.paused) {
@@ -494,11 +495,8 @@ export function attachBackendToSocketClient(backend, client, {
         }
         break
     }
-    if (!fullmsg) {
-      const nickname = command.sender === 'server' ? 'the server' : command.senderNickname
-      fullmsg = `${nickToMessage(nickname)} ${actionmsg}`
-    }
-    backend.showLogMessage(fullmsg, isVerbose)
+    const text = `${nickToMessage(senderNickname)} ${actionmsg}`
+    backend.showLogMessage(text, isVerbose)
   }
 
   client.on('sent-command', command => {