From 895619545e629b8c03d09f8685e2aa71f84aa92a Mon Sep 17 00:00:00 2001 From: Florrie Date: Sun, 24 Mar 2019 10:41:25 -0300 Subject: Disallow creating rules on no-hostname pages --- extension/popup/main.js | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'extension') diff --git a/extension/popup/main.js b/extension/popup/main.js index 1bf653a..1dc39f4 100644 --- a/extension/popup/main.js +++ b/extension/popup/main.js @@ -332,6 +332,11 @@ function loadRuleList({tab, siteSettings, selectRule}) { createRuleButton.appendChild(document.createTextNode('Create Rule')); + if (!new URL(tab.url).hostname) { + createRuleButton.disabled = true; + createRuleButton.title = `Sorry, this page doesn't appear to have a hostname. We can't create a rule here.`; + } + createRuleButton.addEventListener('click', () => { const {hostnameParts} = getURLParts(tab.url); const rule = { -- cgit 1.3.0-6-gf8a5