From ee59d6acd5504a517aae692d758c9ea223644a25 Mon Sep 17 00:00:00 2001 From: "(quasar) nebula" Date: Sun, 6 Apr 2025 17:31:32 -0300 Subject: data: withConstitutedArtwork: don't pass find through The whole point of constituting artworks in advance is so that they exist with a stable identity having been collected into artworkData during save() from various data loading steps. (The new data check reportOrphanedArtworks confirms this at runtime.) We already included artworkData in linkWIkiDataSpec for exactly this purpose, so just drop the 'find' dependency and transfer here. As a result, constitutibleArtworkList has no dependencies of its own, and dependencies on coverArtworks, trackArtworks, etc come only from earlier steps, i.e. deciding whether or not to constitute an artwork in the first place. --- src/data/composite/wiki-data/withConstitutedArtwork.js | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src') diff --git a/src/data/composite/wiki-data/withConstitutedArtwork.js b/src/data/composite/wiki-data/withConstitutedArtwork.js index 3eb3c893..16faa2a9 100644 --- a/src/data/composite/wiki-data/withConstitutedArtwork.js +++ b/src/data/composite/wiki-data/withConstitutedArtwork.js @@ -18,8 +18,6 @@ export default templateCompositeFrom({ { dependencies: [ input.myself(), - 'find', - input('fileExtensionFromThingProperty'), input('artistContribsFromThingProperty'), input('artistContribsArtistProperty'), @@ -28,8 +26,6 @@ export default templateCompositeFrom({ compute: (continuation, { [input.myself()]: myself, - ['find']: find, - [input('fileExtensionFromThingProperty')]: fileExtensionFromThingProperty, [input('artistContribsFromThingProperty')]: artistContribsFromThingProperty, [input('artistContribsArtistProperty')]: artistContribsArtistProperty, @@ -38,8 +34,6 @@ export default templateCompositeFrom({ ['#constitutedArtwork']: Object.assign(new thingConstructors.Artwork, { thing: myself, - find: find, - fileExtensionFromThingProperty, artistContribsFromThingProperty, artistContribsArtistProperty, -- cgit 1.3.0-6-gf8a5