From 3f2d714478a7c9582c492b9cdacc364cb63f417d Mon Sep 17 00:00:00 2001
From: "(quasar) nebula" <qznebula@protonmail.com>
Date: Sun, 20 Apr 2025 11:09:14 -0300
Subject: client: sidebar-search: lots of obscure filter-related fixes

---
 src/static/js/client/sidebar-search.js | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

(limited to 'src/static/js/client/sidebar-search.js')

diff --git a/src/static/js/client/sidebar-search.js b/src/static/js/client/sidebar-search.js
index b6008d28..051ba079 100644
--- a/src/static/js/client/sidebar-search.js
+++ b/src/static/js/client/sidebar-search.js
@@ -677,6 +677,8 @@ function clearSidebarSearch() {
 }
 
 function clearSidebarFilter() {
+  const {session} = info;
+
   toggleSidebarSearchFilter(session.activeFilterType);
 
   forEachFilter((_type, filterLink) => {
@@ -857,12 +859,13 @@ function showFilterElements(results) {
   let shownAny = false;
 
   forEachFilter((type, filterLink) => {
+    filterLink.classList.remove('shown', 'hidden');
+
     if (allReferenceTypes.includes(type)) {
       shownAny = true;
       cssProp(filterLink, 'display', null);
     } else {
       cssProp(filterLink, 'display', 'none');
-      filterLink.classList.remove('shown', 'hidden');
     }
   });
 
@@ -1211,8 +1214,10 @@ function toggleSidebarSearchFilter(toggleType) {
         filterLink.classList.add(filterActive ? 'shown' : 'hidden');
       }
 
-      shownAnyResults =
-        fillResultElements(session.activeQueryResults, {filterType});
+      if (session.activeQueryResults) {
+        shownAnyResults =
+          fillResultElements(session.activeQueryResults, {filterType});
+      }
 
       session.activeFilterType = filterType;
     } else {
@@ -1256,6 +1261,8 @@ function forgetRecentSidebarSearch() {
 
   session.activeQuery = null;
   session.activeQueryResults = null;
+
+  clearSidebarFilter();
 }
 
 async function handleDroppedIntoSearchInput(domEvent) {
-- 
cgit 1.3.0-6-gf8a5