From 895712f5a0381c41557c6d306d6697019368bb7b Mon Sep 17 00:00:00 2001
From: "(quasar) nebula" <qznebula@protonmail.com>
Date: Wed, 30 Aug 2023 15:33:46 -0300
Subject: data: clean up Thing.composite.from debug messaging

* print annotation next to every log message, instead of just
  the begin/end messages

* add Thing.composite.debug() to conveniently wrap one property
  access

* don't output (and don't access) track album in inspect.custom
  when depth < 0
---
 src/data/things/track.js | 40 ++++++++++++++--------------------------
 1 file changed, 14 insertions(+), 26 deletions(-)

(limited to 'src/data/things/track.js')

diff --git a/src/data/things/track.js b/src/data/things/track.js
index dc1f5f2a..8ddf3624 100644
--- a/src/data/things/track.js
+++ b/src/data/things/track.js
@@ -604,38 +604,26 @@ export class Track extends Thing {
       ]),
   };
 
-  [inspect.custom]() {
-    const base = Thing.prototype[inspect.custom].apply(this);
+  [inspect.custom](depth) {
+    const parts = [];
 
-    const rereleasePart =
-      (this.originalReleaseTrackByRef
-        ? `${color.yellow('[rerelease]')} `
-        : ``);
+    parts.push(Thing.prototype[inspect.custom].apply(this));
 
-    const {album, dataSourceAlbum} = this;
+    if (this.originalReleaseTrackByRef) {
+      parts.unshift(`${color.yellow('[rerelease]')} `);
+    }
 
-    const albumName =
-      (album
-        ? album.name
-        : dataSourceAlbum?.name);
-
-    const albumIndex =
-      albumName &&
-        (album
-          ? album.tracks.indexOf(this)
-          : dataSourceAlbum.tracks.indexOf(this));
-
-    const trackNum =
-      albumName &&
+    let album;
+    if (depth >= 0 && (album = this.album ?? this.dataSourceAlbum)) {
+      const albumName = album.name;
+      const albumIndex = album.tracks.indexOf(this);
+      const trackNum =
         (albumIndex === -1
           ? '#?'
           : `#${albumIndex + 1}`);
+      parts.push(` (${color.yellow(trackNum)} in ${color.green(albumName)})`);
+    }
 
-    const albumPart =
-      albumName
-        ? ` (${color.yellow(trackNum)} in ${color.green(albumName)})`
-        : ``;
-
-    return rereleasePart + base + albumPart;
+    return parts.join('');
   }
 }
-- 
cgit 1.3.0-6-gf8a5