From f3d98f5ea63db7f7b2155e7efb0812f025c5bcf3 Mon Sep 17 00:00:00 2001
From: "(quasar) nebula" <qznebula@protonmail.com>
Date: Sat, 23 Sep 2023 20:35:57 -0300
Subject: data, test: collate update description from composition inputs

---
 src/data/things/composite.js              | 11 +++++++
 test/unit/data/composite/compositeFrom.js | 52 +++++++++++++++++++++++++++++--
 2 files changed, 61 insertions(+), 2 deletions(-)

diff --git a/src/data/things/composite.js b/src/data/things/composite.js
index c0f0ab0..34e550a 100644
--- a/src/data/things/composite.js
+++ b/src/data/things/composite.js
@@ -837,6 +837,16 @@ export function compositeFrom(description) {
       .filter(dependency => isInputToken(dependency))
       .some(token => getInputTokenShape(token) === 'input.updateValue');
 
+  // Update descriptions passed as the value in an input.updateValue() token,
+  // as provided as inputs for this composition.
+  const inputUpdateDescriptions =
+    Object.values(description.inputs ?? {})
+      .map(token =>
+        (getInputTokenShape(token) === 'input.updateValue'
+          ? getInputTokenValue(token)
+          : null))
+      .filter(Boolean);
+
   const base = composition.at(-1);
   const steps = composition.slice();
 
@@ -1396,6 +1406,7 @@ export function compositeFrom(description) {
     constructedDescriptor.update =
       Object.assign(
         {...description.update ?? {}},
+        ...inputUpdateDescriptions,
         ...stepUpdateDescriptions.flat());
   }
 
diff --git a/test/unit/data/composite/compositeFrom.js b/test/unit/data/composite/compositeFrom.js
index faeef59..6ae1e7b 100644
--- a/test/unit/data/composite/compositeFrom.js
+++ b/test/unit/data/composite/compositeFrom.js
@@ -172,7 +172,7 @@ t.test(`compositeFrom: dependencies from inputs`, t => {
 });
 
 t.test(`compositeFrom: update from various sources`, t => {
-  t.plan(2);
+  t.plan(3);
 
   const match = {
     flags: {update: true, expose: true, compose: false},
@@ -232,6 +232,54 @@ t.test(`compositeFrom: update from various sources`, t => {
     });
 
     t.match(composite, match);
-    t.equal(debugComposite(() => composite.expose.transform('foo')), 'Xx_foofoo_xX');
+    t.equal(composite.expose.transform('foo'), 'Xx_foofoo_xX');
+  });
+
+  t.test(`compositeFrom: update from inputs`, t => {
+    t.plan(3);
+
+    const composite = compositeFrom({
+      inputs: {
+        myInput: input.updateValue({
+          validate: isString,
+          default: 'foo',
+        }),
+      },
+
+      steps: [
+        {
+          dependencies: [input('myInput')],
+          compute: (continuation, {
+            [input('myInput')]: value,
+          }) => continuation({
+            '#value': `Xx_${value.repeat(2)}_xX`,
+          }),
+        },
+
+        {
+          dependencies: ['#value'],
+          transform: (_value, continuation, {'#value': value}) =>
+            continuation(value),
+        },
+      ],
+    });
+
+    let continuationValue = null;
+    const continuation = value => {
+      continuationValue = value;
+      return continuationSymbol;
+    };
+
+    t.match(composite, {
+      ...match,
+
+      flags: {update: true, expose: true, compose: true},
+    });
+
+    t.equal(
+      composite.expose.transform('foo', continuation),
+      continuationSymbol);
+
+    t.equal(continuationValue, 'Xx_foofoo_xX');
   });
 });
-- 
cgit 1.3.0-6-gf8a5