From 1d3eac688b0d800323a1db9fcaf598005f50051a Mon Sep 17 00:00:00 2001 From: "(quasar) nebula" Date: Sat, 13 Jan 2024 17:12:57 -0400 Subject: content, css: flatten .reveal into .image-container --- src/content/dependencies/image.js | 43 ++++++++++++++------------- src/static/site6.css | 6 ---- tap-snapshots/test/snapshot/image.js.test.cjs | 30 +++++++++---------- 3 files changed, 37 insertions(+), 42 deletions(-) diff --git a/src/content/dependencies/image.js b/src/content/dependencies/image.js index bc52321a..a39acca3 100644 --- a/src/content/dependencies/image.js +++ b/src/content/dependencies/image.js @@ -136,12 +136,17 @@ export default { slots.height && {height: slots.height}, ]); - if (!originalSrc || isMissingImageFile) { - return prepare( - html.tag('div', {class: 'image-text-area'}, - (html.isBlank(slots.missingSourceContent) - ? language.$('misc.missingImage') - : slots.missingSourceContent))); + const isPlaceholder = + !originalSrc || isMissingImageFile; + + if (isPlaceholder) { + return ( + prepare( + html.tag('div', {class: 'image-text-area'}, + (html.isBlank(slots.missingSourceContent) + ? language.$('misc.missingImage') + : slots.missingSourceContent)), + 'visible')); } let reveal = null; @@ -314,15 +319,6 @@ export default { html.tag('div', {class: 'image-outer-area'}, wrapped); - if (willReveal) { - wrapped = - html.tag('div', {class: 'reveal'}, - images.revealStatic && - {class: 'has-reveal-thumbnail'}, - - wrapped); - } - if (willSquare) { wrapped = html.tag('div', {class: 'square-content'}, @@ -331,17 +327,24 @@ export default { wrapped = html.tag('div', {class: 'image-container'}, - willLink && - {class: 'has-link'}, - willSquare && {class: 'square'}, typeof slots.link === 'string' && {class: 'no-image-preview'}, - !originalSrc && - {class: 'placeholder-image'}, + (isPlaceholder + ? {class: 'placeholder-image'} + : [ + willLink && + {class: 'has-link'}, + + willReveal && + {class: 'reveal'}, + + revealSrc && + {class: 'has-reveal-thumbnail'}, + ]), visibility === 'hidden' && {class: 'js-hide'}, diff --git a/src/static/site6.css b/src/static/site6.css index b00dd595..3ad438c6 100644 --- a/src/static/site6.css +++ b/src/static/site6.css @@ -1171,12 +1171,6 @@ img.pixelate, .pixelate img { image-rendering: crisp-edges; } -.reveal { - position: relative; - width: 100%; - height: 100%; -} - .reveal-text-container { position: absolute; top: 15px; diff --git a/tap-snapshots/test/snapshot/image.js.test.cjs b/tap-snapshots/test/snapshot/image.js.test.cjs index ffc7d43a..5661c9c7 100644 --- a/tap-snapshots/test/snapshot/image.js.test.cjs +++ b/tap-snapshots/test/snapshot/image.js.test.cjs @@ -6,21 +6,19 @@ */ 'use strict' exports[`test/snapshot/image.js > TAP > image (snapshot) > content warnings via tags 1`] = ` -
-
-
-
- - - - -
- too cool for school -
- click to show -
+
+
+
+ + + + +
+ too cool for school +
+ click to show
-
+
@@ -36,11 +34,11 @@ exports[`test/snapshot/image.js > TAP > image (snapshot) > link with file size 1 ` exports[`test/snapshot/image.js > TAP > image (snapshot) > missing image path 1`] = ` -
(This image file is missing)
+
(This image file is missing)
` exports[`test/snapshot/image.js > TAP > image (snapshot) > missing image path w/ missingSourceContent 1`] = ` -
Cover's missing, whoops
+
Cover's missing, whoops
` exports[`test/snapshot/image.js > TAP > image (snapshot) > source missing 1`] = ` -- cgit 1.3.0-6-gf8a5