From 1cf06b4898b517993a171a5f6c39d00609105253 Mon Sep 17 00:00:00 2001 From: "(quasar) nebula" Date: Wed, 30 Aug 2023 16:32:40 -0300 Subject: data, infra: only make exposed properties enumerable This prevents them from being displayed in, for example, node-tap mismatched test case output. AFAIK, we generally don't depend on the enumerability of properties anywhere in hsmusic's codebase, and it doesn't really make sense for unexposed properties to be enumerable in the first place. --- src/data/things/cacheable-object.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data/things/cacheable-object.js b/src/data/things/cacheable-object.js index 24a6cf01..62c23d13 100644 --- a/src/data/things/cacheable-object.js +++ b/src/data/things/cacheable-object.js @@ -141,7 +141,7 @@ export default class CacheableObject { const definition = { configurable: false, - enumerable: true, + enumerable: flags.expose, }; if (flags.update) { -- cgit 1.3.0-6-gf8a5