« get me outta code hell

hsmusic-wiki - HSMusic - static wiki software cataloguing collaborative creation
about summary refs log tree commit diff
path: root/src/content
diff options
context:
space:
mode:
Diffstat (limited to 'src/content')
-rw-r--r--src/content/dependencies/generateCoverArtworkArtTagDetails.js23
1 files changed, 11 insertions, 12 deletions
diff --git a/src/content/dependencies/generateCoverArtworkArtTagDetails.js b/src/content/dependencies/generateCoverArtworkArtTagDetails.js
index 50571a4f..db69533d 100644
--- a/src/content/dependencies/generateCoverArtworkArtTagDetails.js
+++ b/src/content/dependencies/generateCoverArtworkArtTagDetails.js
@@ -8,11 +8,6 @@ export default {
   query: (artwork) => ({
     linkableArtTags:
       artwork.artTags.filter(linkable),
-
-    mainArtworkLinkableArtTags:
-      (artwork.mainArtwork
-        ? artwork.mainArtwork.artTags.filter(linkable)
-        : null),
   }),
 
   relations: (relation, query, _artwork) => ({
@@ -24,15 +19,19 @@ export default {
   data: (query, artwork) => {
     const data = {};
 
-    data.attachAbove = artwork.attachAbove;
+    const compare = against =>
+      !empty(query.linkableArtTags) &&
+      against &&
+      compareArrays(
+        query.linkableArtTags,
+        against.artTags.filter(linkable));
 
     data.sameAsMainArtwork =
       !artwork.isMainArtwork &&
-      query.mainArtworkLinkableArtTags &&
-      !empty(query.mainArtworkLinkableArtTags) &&
-      compareArrays(
-        query.mainArtworkLinkableArtTags,
-        query.linkableArtTags);
+      compare(artwork.mainArtwork);
+
+    data.sameAsAttachedArtwork =
+      compare(artwork.attachedArtwork);
 
     const seenShortNames = new Set();
     const duplicateShortNames = new Set();
@@ -59,7 +58,7 @@ export default {
 
         {class: 'art-tag-details'},
 
-        (data.sameAsMainArtwork && data.attachAbove
+        (data.sameAsAttachedArtwork
           ? html.blank()
        : data.sameAsMainArtwork && relations.artTagLinks.length >= 3
           ? language.$(capsule, 'sameTagsAsMainArtwork')