« get me outta code hell

data: withConstitutedArtwork: don't pass find through - hsmusic-wiki - HSMusic - static wiki software cataloguing collaborative creation
about summary refs log tree commit diff
path: root/src/data
diff options
context:
space:
mode:
author(quasar) nebula <qznebula@protonmail.com>2025-04-06 17:31:32 -0300
committer(quasar) nebula <qznebula@protonmail.com>2025-04-10 16:02:41 -0300
commitee59d6acd5504a517aae692d758c9ea223644a25 (patch)
treebb8d13a551baa71409171b9381c7120f1eae6f94 /src/data
parent10f0b2307639d32f3fd8cdd89ee10da633eb8c07 (diff)
data: withConstitutedArtwork: don't pass find through
The whole point of constituting artworks in advance is so that
they exist with a stable identity having been collected into
artworkData during save() from various data loading steps.
(The new data check reportOrphanedArtworks confirms this at
runtime.) We already included artworkData in linkWIkiDataSpec
for exactly this purpose, so just drop the 'find' dependency
and transfer here.

As a result, constitutibleArtworkList has no dependencies of
its own, and dependencies on coverArtworks, trackArtworks, etc
come only from earlier steps, i.e. deciding whether or not to
constitute an artwork in the first place.
Diffstat (limited to 'src/data')
-rw-r--r--src/data/composite/wiki-data/withConstitutedArtwork.js6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/data/composite/wiki-data/withConstitutedArtwork.js b/src/data/composite/wiki-data/withConstitutedArtwork.js
index 3eb3c893..16faa2a9 100644
--- a/src/data/composite/wiki-data/withConstitutedArtwork.js
+++ b/src/data/composite/wiki-data/withConstitutedArtwork.js
@@ -18,8 +18,6 @@ export default templateCompositeFrom({
     {
       dependencies: [
         input.myself(),
-        'find',
-
         input('fileExtensionFromThingProperty'),
         input('artistContribsFromThingProperty'),
         input('artistContribsArtistProperty'),
@@ -28,8 +26,6 @@ export default templateCompositeFrom({
 
       compute: (continuation, {
         [input.myself()]: myself,
-        ['find']: find,
-
         [input('fileExtensionFromThingProperty')]: fileExtensionFromThingProperty,
         [input('artistContribsFromThingProperty')]: artistContribsFromThingProperty,
         [input('artistContribsArtistProperty')]: artistContribsArtistProperty,
@@ -38,8 +34,6 @@ export default templateCompositeFrom({
         ['#constitutedArtwork']:
           Object.assign(new thingConstructors.Artwork, {
             thing: myself,
-            find: find,
-
             fileExtensionFromThingProperty,
             artistContribsFromThingProperty,
             artistContribsArtistProperty,