« get me outta code hell

exclude re-releases from referencedByTracks prop - hsmusic-wiki - HSMusic - static wiki software cataloguing collaborative creation
about summary refs log tree commit diff
path: root/src/data
diff options
context:
space:
mode:
author(quasar) nebula <qznebula@protonmail.com>2022-05-22 13:17:53 -0300
committer(quasar) nebula <qznebula@protonmail.com>2022-05-22 13:17:53 -0300
commitcaba536171879628837ce2647283526295d4b564 (patch)
tree83e23cba68d0613665687ab8ee9987ab2bba34ae /src/data
parent71d66c237a56a5d67a6cffbc4db9ff0c958fed5c (diff)
exclude re-releases from referencedByTracks prop
Diffstat (limited to 'src/data')
-rw-r--r--src/data/things.js25
1 files changed, 22 insertions, 3 deletions
diff --git a/src/data/things.js b/src/data/things.js
index 18efac47..b4737510 100644
--- a/src/data/things.js
+++ b/src/data/things.js
@@ -294,7 +294,7 @@ Thing.common = {
         expose: {
             dependencies: [singleReferenceProperty, thingDataProperty],
             compute: ({ [singleReferenceProperty]: ref, [thingDataProperty]: thingData }) => (
-                (ref && thingData ? findFn(ref, thingData, {mode: 'quiet'}) : [])
+                (ref && thingData ? findFn(ref, thingData, {mode: 'quiet'}) : null)
             )
         }
     }),
@@ -854,8 +854,27 @@ Track.propertyDescriptors = {
     // Previously known as: (track).references
     referencedTracks: Thing.common.dynamicThingsFromReferenceList('referencedTracksByRef', 'trackData', find.track),
 
-    // Previously known as: (track).referencedBy
-    referencedByTracks: Thing.common.reverseReferenceList('trackData', 'referencedTracks'),
+    // Specifically exclude re-releases from this list - while it's useful to
+    // get from a re-release to the tracks it references, re-releases aren't
+    // generally relevant from the perspective of the tracks being referenced.
+    // Filtering them from data here hides them from the corresponding field
+    // on the site (obviously), and has the bonus of not counting them when
+    // counting the number of times a track has been referenced, for use in
+    // the "Tracks - by Times Referenced" listing page (or other data
+    // processing).
+    referencedByTracks: {
+        flags: {expose: true},
+
+        expose: {
+            dependencies: ['trackData'],
+
+            compute: ({ trackData, [Track.instance]: track }) => (trackData
+                ? (trackData
+                    .filter(t => !t.originalReleaseTrack)
+                    .filter(t => t.referencedTracks?.includes(track)))
+                : [])
+        }
+    },
 
     // Previously known as: (track).flashes
     featuredInFlashes: Thing.common.reverseReferenceList('flashData', 'featuredTracks'),