« get me outta code hell

content: gCommentaryContentHeading: parity w/ gReadCommentaryLine - hsmusic-wiki - HSMusic - static wiki software cataloguing collaborative creation
about summary refs log tree commit diff
path: root/src/content/dependencies
diff options
context:
space:
mode:
author(quasar) nebula <qznebula@protonmail.com>2025-09-23 17:09:52 -0300
committer(quasar) nebula <qznebula@protonmail.com>2025-09-23 17:10:17 -0300
commitc55c061be21178b13b621d80cd8e2b83bba8ef97 (patch)
treeab7a5afacbe272b6853dde28f4ab501c15a9e52d /src/content/dependencies
parent934494b5f3ee610d6473b3ca4c21c80731c213af (diff)
content: gCommentaryContentHeading: parity w/ gReadCommentaryLine
Diffstat (limited to 'src/content/dependencies')
-rw-r--r--src/content/dependencies/generateCommentaryContentHeading.js27
-rw-r--r--src/content/dependencies/generateContentContentHeading.js2
-rw-r--r--src/content/dependencies/generateReadCommentaryLine.js6
3 files changed, 24 insertions, 11 deletions
diff --git a/src/content/dependencies/generateCommentaryContentHeading.js b/src/content/dependencies/generateCommentaryContentHeading.js
index 92405010..cf5667fa 100644
--- a/src/content/dependencies/generateCommentaryContentHeading.js
+++ b/src/content/dependencies/generateCommentaryContentHeading.js
@@ -1,20 +1,31 @@
+import {empty} from '#sugar';
+
 export default {
   contentDependencies: ['generateContentContentHeading'],
   extraDependencies: ['language'],
 
-  relations: (relation, thing) => ({
+  query: (thing) => ({
+    entries:
+      (thing.isTrack
+        ? [...thing.commentary, ...thing.commentaryFromMainRelease]
+        : thing.commentary),
+  }),
+
+  relations: (relation, _query, thing) => ({
     contentContentHeading:
       relation('generateContentContentHeading', thing),
   }),
 
-  data: (thing) => ({
+  data: (query, _thing) => ({
     hasWikiEditorCommentary:
-      thing.commentary
-        .some(entry => entry.isWikiEditorCommentary),
+      query.entries.some(entry => entry.isWikiEditorCommentary),
 
     onlyWikiEditorCommentary:
-      thing.commentary
-        .every(entry => entry.isWikiEditorCommentary),
+      !empty(query.entries) &&
+      query.entries.every(entry => entry.isWikiEditorCommentary),
+
+    hasAnyCommentary:
+      !empty(query.entries),
   }),
 
   generate: (data, relations, {language}) =>
@@ -28,6 +39,8 @@ export default {
             ? language.encapsulate(capsule, 'onlyWikiCommentary')
          : data.hasWikiEditorCommentary
             ? language.encapsulate(capsule, 'withWikiCommentary')
-            : capsule)),
+         : data.hasAnyCommentary
+            ? capsule
+            : null)),
     }),
 };
diff --git a/src/content/dependencies/generateContentContentHeading.js b/src/content/dependencies/generateContentContentHeading.js
index 314ef197..555abb6b 100644
--- a/src/content/dependencies/generateContentContentHeading.js
+++ b/src/content/dependencies/generateContentContentHeading.js
@@ -28,12 +28,14 @@ export default {
       attributes: slots.attributes,
 
       title:
+        slots.string &&
         language.$(slots.string, {
           thing:
             html.tag('i', data.name),
         }),
 
       stickyTitle:
+        slots.string &&
         language.$(slots.string, 'sticky'),
     }),
 };
diff --git a/src/content/dependencies/generateReadCommentaryLine.js b/src/content/dependencies/generateReadCommentaryLine.js
index a7a7a4da..6f99256f 100644
--- a/src/content/dependencies/generateReadCommentaryLine.js
+++ b/src/content/dependencies/generateReadCommentaryLine.js
@@ -12,13 +12,11 @@ export default {
 
   data: (query, _thing) => ({
     hasWikiEditorCommentary:
-      query.entries
-        .some(entry => entry.isWikiEditorCommentary),
+      query.entries.some(entry => entry.isWikiEditorCommentary),
 
     onlyWikiEditorCommentary:
       !empty(query.entries) &&
-      query.entries
-        .every(entry => entry.isWikiEditorCommentary),
+      query.entries.every(entry => entry.isWikiEditorCommentary),
 
     hasAnyCommentary:
       !empty(query.entries),