« get me outta code hell

content: drop "with other artists" for real - hsmusic-wiki - HSMusic - static wiki software cataloguing collaborative creation
about summary refs log tree commit diff
diff options
context:
space:
mode:
author(quasar) nebula <qznebula@protonmail.com>2026-01-11 11:36:51 -0400
committer(quasar) nebula <qznebula@protonmail.com>2026-01-11 11:36:51 -0400
commit457dddfcc40f97de8263a842d47fe1493a89150b (patch)
treea9bd3fc4c8c677d55363a3fe9a7acf81b23770e9
parent953f09124c4cddeac78ffa57cfc6dc88d7720d74 (diff)
content: drop "with other artists" for real
-rw-r--r--src/content/dependencies/generateArtistInfoPageArtworksChunkItem.js5
-rw-r--r--src/content/dependencies/generateArtistInfoPageChunkItem.js8
-rw-r--r--src/content/dependencies/generateArtistInfoPageOtherArtistLinks.js28
-rw-r--r--src/strings-default.yaml8
4 files changed, 0 insertions, 49 deletions
diff --git a/src/content/dependencies/generateArtistInfoPageArtworksChunkItem.js b/src/content/dependencies/generateArtistInfoPageArtworksChunkItem.js
index e3ba5342..993ef706 100644
--- a/src/content/dependencies/generateArtistInfoPageArtworksChunkItem.js
+++ b/src/content/dependencies/generateArtistInfoPageArtworksChunkItem.js
@@ -21,9 +21,6 @@ export default {
         ? relation('linkTrack', contrib.thing.thing)
         : null),
 
-    otherArtistLinks:
-      relation('generateArtistInfoPageOtherArtistLinks', [contrib]),
-
     originDetails:
       relation('transformContent', contrib.thing.originDetails),
   }),
@@ -48,8 +45,6 @@ export default {
 
   generate: (data, relations, slots, {html, language}) =>
     relations.template.slots({
-      otherArtistLinks: relations.otherArtistLinks,
-
       annotation:
         language.encapsulate('artistPage.creditList.entry.artwork.accent', workingCapsule => {
           const workingOptions = {};
diff --git a/src/content/dependencies/generateArtistInfoPageChunkItem.js b/src/content/dependencies/generateArtistInfoPageChunkItem.js
index cf45a37c..457e82f5 100644
--- a/src/content/dependencies/generateArtistInfoPageChunkItem.js
+++ b/src/content/dependencies/generateArtistInfoPageChunkItem.js
@@ -22,10 +22,6 @@ export default {
       mutable: false,
     },
 
-    otherArtistLinks: {
-      validate: v => v.strictArrayOf(v.isHTML),
-    },
-
     rereleaseTooltip: {
       type: 'html',
       mutable: false,
@@ -67,10 +63,6 @@ export default {
                   text: language.$(entryCapsule, 'firstRelease.term'),
                   tooltip: slots.firstReleaseTooltip,
                 });
-            } else if (!empty(slots.otherArtistLinks)) {
-              workingCapsule += '.withArtists';
-              workingOptions.artists =
-                language.formatConjunctionList(slots.otherArtistLinks);
             }
 
             if (!html.isBlank(slots.annotation)) {
diff --git a/src/content/dependencies/generateArtistInfoPageOtherArtistLinks.js b/src/content/dependencies/generateArtistInfoPageOtherArtistLinks.js
deleted file mode 100644
index afb61c33..00000000
--- a/src/content/dependencies/generateArtistInfoPageOtherArtistLinks.js
+++ /dev/null
@@ -1,28 +0,0 @@
-import {unique} from '#sugar';
-
-export default {
-  query(contribs) {
-    const associatedContributionsByOtherArtists =
-      contribs
-        .flatMap(ownContrib =>
-          ownContrib.associatedContributions
-            .filter(associatedContrib =>
-              associatedContrib.artist !== ownContrib.artist));
-
-    const otherArtists =
-      unique(
-        associatedContributionsByOtherArtists
-          .map(contrib => contrib.artist));
-
-    return {otherArtists};
-  },
-
-  relations: (relation, query) => ({
-    artistLinks:
-      query.otherArtists
-        .map(artist => relation('linkArtist', artist)),
-  }),
-
-  generate: (relations) =>
-    relations.artistLinks,
-};
diff --git a/src/strings-default.yaml b/src/strings-default.yaml
index 0bfb6b4c..b79dd67f 100644
--- a/src/strings-default.yaml
+++ b/src/strings-default.yaml
@@ -1326,14 +1326,6 @@ artistPage:
 
       withCitation: "{ENTRY} ({CITATION})"
 
-      # withArtists:
-      #   This lists co-artists or co-contributors, depending on how
-      #   the artist themselves was credited.
-
-      withArtists: "{ENTRY} (with {ARTISTS})"
-
-      withArtists.withAnnotation: "{ENTRY} — {ANNOTATION} (with {ARTISTS})"
-
       # rerelease:
       #   Tracks which aren't the original release don't display co-
       #   artists or contributors, and get dimmed a little compared